-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[druid] Adding verbose_name to editable columns #5249
[druid] Adding verbose_name to editable columns #5249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5249 +/- ##
=======================================
Coverage 60.76% 60.76%
=======================================
Files 258 258
Lines 19701 19701
Branches 1970 1970
=======================================
Hits 11972 11972
Misses 7720 7720
Partials 9 9
Continue to review full report at Codecov.
|
lgtm |
Actually, verbose name is set it get_metrics, so wouldn't the field just be overwritten if someone tries to edit it? |
@michellethomas this is for a Druid column rather than a metric. |
oh well then ignore my comment lgtm |
LGTM |
(cherry picked from commit 7de5023)
This PR adds the Druid column verbose name as an editable column, inline with SQLA columns.
to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa